chore: Add dyn Crypto trait to PrecompileFn

[kevaundray]

No description provided.

[kevaundray]

We now check for this in self.precompiles.execute -- will revert this and just deref the fn pointer, then explicitly pass in the dyn trait

[kevaundray]

666a47c

[mattsse]

this is quite an invasive change just to make the sha256 fn configurable

perhaps a better approach would be to have dedicated precompile fns that use different impls and then simply replace the entire precompile

[kevaundray]

this is quite an invasive change just to make the sha256 fn configurable

perhaps a better approach would be to have dedicated precompile fns that use different impls and then simply replace the entire precompile

This would be for all of the precompiles fwiw -- I just did sha256 first to show it working.

I was hoping to not need to replace the entire precompile because the main thing we care about switching out is the pure cryptography part and not the EVM related parts

[kevaundray]

@mattsse we would essentially be adding all of these methods:

revm/crates/precompile/src/crypto.rs

Line 42 in 3d00601

pub trait CryptoProvider: Send + Sync + 'static {

[codspeed-hq]

CodSpeed Performance Report

Merging #2772 will not alter performance

_{Comparing kevaundray:kw/crypto-trait-in-precompiles-struct (fd1b3f7) with main (a46aa4a)}

Summary

✅ 171 untouched benchmarks

[rakita]

This is contained only within Precompile, so it does not change PrecompileProvider and how it is handled. And intention is to have an exchangeable crypto module for every precompile, so it is easy to use.

[rakita]

Good as a skeleton.