Skip to content

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Mar 28, 2025

In #2327 , the bls benchmarks were added in a more modular way -- this PR moves all of the previous benchmarks in bench.rs into their own module to follow the same structure

@kevaundray kevaundray changed the title chore: Mvoe all benchmarks into their own module like eip2537 chore: Move all benchmarks into their own module like eip2537 Mar 28, 2025
@kevaundray kevaundray marked this pull request as ready for review March 28, 2025 10:07
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #2335 will not alter performance

Comparing kevaundray:kw/small-refactor-benchmarks (1f25eb5) with main (7a98764)

Summary

✅ 21 untouched benchmarks
🆕 5 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 bn128 add precompile N/A 22 µs N/A
🆕 bn128 mul precompile N/A 343.2 µs N/A
🆕 ecpairing precompile N/A 4.9 ms N/A
🆕 ecrecover precompile N/A 202.4 µs N/A
🆕 kzg precompile N/A 7.5 ms N/A
⁉️ precompile bench | bn128 add precompile 22 µs N/A N/A
⁉️ precompile bench | bn128 mul precompile 343.2 µs N/A N/A
⁉️ precompile bench | ecpairing precompile 4.9 ms N/A N/A
⁉️ precompile bench | kzg precompile 7.5 ms N/A N/A

@rakita rakita merged commit db1d35e into bluealloy:main Mar 28, 2025
28 of 29 checks passed
This was referenced Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants