Skip to content

Conversation

Ayushdubey86
Copy link
Contributor

@Ayushdubey86 Ayushdubey86 commented Feb 15, 2025

This should do it, not much sure about indentations though. do let me know if it requires any further change @rakita!
pr being for this issue

i have addressed this issue as well
"This does not look great. Can you create one bls12_381_const.rs file, scan all bls12 files for constant and move them to that file?"

Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #2085 will not alter performance

Comparing Ayushdubey86:Split-Precompile-Constants-out-of-Individual-Modules-#2081 (ec26a86) with main (c525b5e)

Summary

✅ 8 untouched benchmarks

@rakita rakita merged commit 02c9b67 into bluealloy:main Feb 19, 2025
28 checks passed
This was referenced Feb 18, 2025
mattsse added a commit that referenced this pull request Feb 20, 2025
@Ayushdubey86 Ayushdubey86 deleted the Split-Precompile-Constants-out-of-Individual-Modules-#2081 branch February 26, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants