Skip to content

Conversation

rakita
Copy link
Member

@rakita rakita commented Dec 26, 2024

In most cases, we would not need a reference but concrete type. Some block types (gas, basefee) were changes to smaller types.

Copy link

codspeed-hq bot commented Dec 26, 2024

CodSpeed Performance Report

Merging #1957 will degrade performances by 2.47%

Comparing rakita/align_block_trait (615c3cf) with main (7d060e1)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rakita/align_block_trait Change
`precompile bench ecrecover precompile` 195.2 µs 200.2 µs

@rakita rakita force-pushed the rakita/align_block_trait branch from eb09c36 to 615c3cf Compare December 26, 2024 21:53
@rakita
Copy link
Member Author

rakita commented Dec 30, 2024

This change does not touch precompile, it is a flaky test

1 similar comment
@rakita
Copy link
Member Author

rakita commented Dec 30, 2024

This change does not touch precompile, it is a flaky test

@rakita rakita merged commit 543b4bb into main Dec 30, 2024
27 of 28 checks passed
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
@rakita rakita deleted the rakita/align_block_trait branch December 30, 2024 10:38
This was referenced Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant