Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(precompile): use secp256k1 global context for ecrecover #1845

Merged
merged 2 commits into from
Nov 4, 2024
Merged

perf(precompile): use secp256k1 global context for ecrecover #1845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877949c
perf(precompile): use secp256k1 global context for ecrecover
Rjected Nov 1, 2024
d9798a2
remove secp var
Rjected Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/precompile/src/secp256k1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ mod secp256k1 {
use revm_primitives::{alloy_primitives::B512, keccak256, B256};
use secp256k1::{
ecdsa::{RecoverableSignature, RecoveryId},
Message, Secp256k1,
Message, SECP256K1,
};

// Silence the unused crate dependency warning.
Expand All @@ -56,9 +56,8 @@ mod secp256k1 {
let recid = RecoveryId::from_i32(recid as i32).expect("recovery ID is valid");
let sig = RecoverableSignature::from_compact(sig.as_slice(), recid)?;

let secp = Secp256k1::new();
let msg = Message::from_digest(msg.0);
let public = secp.recover_ecdsa(&msg, &sig)?;
let public = SECP256K1.recover_ecdsa(&msg, &sig)?;

let mut hash = keccak256(&public.serialize_uncompressed()[1..]);
hash[..12].fill(0);
Expand Down