Skip to content

Chore: some no_std cleanup #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

Chore: some no_std cleanup #1834

merged 2 commits into from
Oct 24, 2024

Conversation

prestwich
Copy link
Contributor

  • moves printer cfg flag to module level, instead of annotating every item in the module
  • adds some missing imports to tests in no_std
  • changes an impl from feature-gated std::error::Error to non-gated core::error::Error

rakita
rakita approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 51d50f6 into bluealloy:main Oct 24, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Closed
This was referenced Dec 6, 2024
Closed
Closed
This was referenced Dec 16, 2024
Closed
Open
Open
Open
This was referenced Dec 23, 2024
Open
Closed
Open
Closed
This was referenced Dec 31, 2024
Open
Open
Open
Open
This was referenced Jan 7, 2025
Open
Closed
This was referenced Feb 7, 2025
Closed
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @rakita