Disable pytest-pystack for test depending on pytester fixture#11
Merged
pablogsal merged 1 commit intobloomberg:mainfrom Nov 16, 2024
Merged
Disable pytest-pystack for test depending on pytester fixture#11pablogsal merged 1 commit intobloomberg:mainfrom
pablogsal merged 1 commit intobloomberg:mainfrom
Conversation
pablogsal
requested changes
Apr 29, 2024
Czaki
force-pushed
the
pytester_workaround
branch
2 times, most recently
from
ce1285a to
bdaaada
Compare
Contributor
Author
|
@pablogsal could you trigger tests? |
Contributor
Author
|
@pablogsal bump |
pablogsal
force-pushed
the
pytester_workaround
branch
from
1311e11 to
1fc7c2a
Compare
pablogsal
approved these changes
Nov 16, 2024
This is only a workaround, maybe a better solution will be to implement some stack mechanism, that will be enabled if pytester fixture is used. Signed-off-by: Grzegorz Bokota <bokota+github@gmail.com>
pablogsal
force-pushed
the
pytester_workaround
branch
from
1fc7c2a to
54ab688
Compare
Member
|
Will make a release later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #10
Describe your changes
Disable
pytest-pystackon test that usespytesterfixture (that starts test in test).Testing performed
Run tests that crash on main with this change and it works now.
Additional context
This is only a workaround, maybe a better solution will be to implement some stack mechanism, that will be enabled if
pytesterfixture is used.