Fix incompatibility with the 'flaky' plugin #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'flaky' plugging does some questionable activity and forces our plugin to be called with itself. This causes us to wrap our own test wrapper and therefore create nested Trackers, which is not allowed. To fix this, unwrap the test function at the end of the run. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Seems that one of the latest memray versions has broken the test suite because we don't track Cython calls anymore. Fix this by not matching the Cython file but just the function itself.
gaborbernat
reviewed
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'flaky' plugging does some cuestionable activity and forces our
plugin to be called with itself. This causes us to wrap our own test
wrapper and therefore create nested Trackers, which is not allowed.
To fix this, unwrap the test function at the end of the run.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.