Skip to content

Conversation

aelsayed95
Copy link
Contributor

Closes: #50

Describe your changes

  • Remove tox.ini and move coverage cfg to pyproject.toml
  • Add a github workflow to run coverage on PRs

Testing performed
WIP

Additional context
Add any other context about your contribution here.

Signed-off-by: Aya Elsayed <ayah.ehab11@gmail.com>
Signed-off-by: Aya Elsayed <ayah.ehab11@gmail.com>
@aelsayed95 aelsayed95 force-pushed the removeTox branch 13 times, most recently from 50dff8d to 27a5b02 Compare April 25, 2023 23:28
Signed-off-by: Aya Elsayed <ayah.ehab11@gmail.com>
@aelsayed95 aelsayed95 marked this pull request as ready for review April 25, 2023 23:35
@aelsayed95 aelsayed95 changed the title Remove tox Remove tox.ini + Add a github workflow to run pycoverage Apr 25, 2023
@pablogsal
Copy link
Member

LGTM

Excellent job! ✨

@pablogsal pablogsal changed the title Remove tox.ini + Add a github workflow to run pycoverage Remove tox.ini and add a Github workflow to run pycoverage Apr 26, 2023
@pablogsal pablogsal merged commit 7800009 into bloomberg:main Apr 26, 2023
pablogsal pushed a commit to pablogsal/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile
pablogsal pushed a commit to Helithumper/pystack that referenced this pull request May 22, 2023
Extracting out variables, formatting

Reformatting command

Improved command that opens the existing container if it exists

Including Docker RM command

Removed PDB reference from git

Added Pytest-Fork, Cleanup

Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80)

We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets.

Run Sphinx in nitpicky mode

Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com>

Add a check in the Makefile for RELEASE

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Added towncrier step to the CI

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Add --keep flag on towncrier

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>

Build elfutils in Dockerfile

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tox.ini and relocate the coverage configuration
2 participants