Skip to content

Upgrade to the latest cibuildwheel and elfutils #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

godlygeek
Copy link
Contributor

@godlygeek godlygeek commented May 21, 2025

These upgrades are necessary to support Python 3.14, but necessitate dropping support for Python 3.7 and musllinux_1_1.

godlygeek added 4 commits May 21, 2025 11:42
This is necessary for building Python 3.14 wheels.

Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
The `musllinux_1_1` image is past end of life.
Switch to `musllinux_1_2` instead.

Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
Python 3.7 has been end-of-life since June 2023, and is not supported by
any version of cibuildwheel which also supports Python 3.14.

Continue testing that we can attach to a running Python 3.7 process or
debug a core file left by one from a newer version of Python.

Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
Drop our patch for correctly handling core files with non-contiguous
segments. This patch made it into the upstream 0.191 release.

Work around some new warnings that appear when building `elfutils` on
musl by setting `-Wno-error` in both `CFLAGS` and `CXXFLAGS`.

While we're at it, standardize the flags used for building `elfutils`
across `manylinux` and `musllinux`.

Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
@godlygeek godlygeek self-assigned this May 21, 2025
@godlygeek godlygeek requested a review from pablogsal May 21, 2025 15:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (8f8142a) to head (0789c64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files          46       46           
  Lines        6249     6249           
  Branches      458      458           
=======================================
  Hits         5166     5166           
  Misses       1083     1083           
Flag Coverage Δ
cpp 82.66% <ø> (ø)
python_and_cython 82.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pablogsal pablogsal enabled auto-merge (rebase) May 21, 2025 20:56
@pablogsal pablogsal merged commit ca83721 into bloomberg:main May 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants