Skip to content

Conversation

pablogsal
Copy link
Member

Arch is more aggressively stripping out binaries and the tests that rely
on debug symbols fail due to insufficient debugging information. Getting
these debugging symbols by hand is a bit of a mess because Arch doesn't
publish debug packages in the same index. On the other hand Arch
provides a debuginfod server, so we can leverage that when running the
tests.

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

Arch is more aggressively stripping out binaries and the tests that rely
on debug symbols fail due to insufficient debugging information. Getting
these debugging symbols by hand is a bit of a mess because Arch doesn't
publish debug packages in the same index. On the other hand Arch
provides a debuginfod server, so we can leverage that when running the
tests.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
The mypy check is failing due to a mismatch between signature and the
return type. Looks like the return value can be removed, as the only
call to the function expects an iterable, matching the function
signature.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal requested a review from godlygeek May 13, 2024 22:13
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 3edc7ef into bloomberg:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants