Pin pyinstaller to avoid failure in Alpine #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something in pyinstaller 6 is making the relocatable core fail in Alpine. Meanwhile we investigate, pin pyinstaller to some version less than 6 to get the CI green again. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
force-pushed
the
pyinstaller
branch
from
2aa1cdd to
37d9808
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 90.06% 89.91% -0.15%
==========================================
Files 48 48
Lines 5574 5496 -78
Branches 873 873
==========================================
- Hits 5020 4942 -78
Misses 554 554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in pyinstaller 6 is making the relocatable core fail in
Alpine. Meanwhile we investigate, pin pyinstaller to some version less
than 6 to get the CI green again.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.