Handle failures to unwind better #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 90.34% 90.19% -0.15%
==========================================
Files 47 47
Lines 5480 5489 +9
Branches 863 863
==========================================
Hits 4951 4951
- Misses 529 538 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
godlygeek
force-pushed
the
handle_unwind_failures_better
branch
from
7334208 to
e212cbd
Compare
We can fail to find any frames even without `libdw` reporting an error,
and in that case `dwfl_errmsg` can return a `nullptr`, which we cannot
pass to the `std::string` constructor.
This fixes a
Engine error: basic_string::_S_construct null not valid
when unwinding has failed.
Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
handle_unwind_failures_better
branch
from
e212cbd to
cd75978
Compare
pablogsal
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can fail to find any frames even without
libdwreporting an error, and in that casedwfl_errmsgcan return anullptr, which we cannot pass to thestd::stringconstructor.This fixes a
when unwinding has failed.