Skip to content

Address Zizmor findings and enable Zizmor in CI - #922

Merged
godlygeek merged 6 commits into
bloomberg:mainfrom
tnytown:tnytown/ci-security
May 19, 2026
Merged

Address Zizmor findings and enable Zizmor in CI#922
godlygeek merged 6 commits into
bloomberg:mainfrom
tnytown:tnytown/ci-security

Conversation

@tnytown

@tnytown tnytown commented May 18, 2026

Copy link
Copy Markdown
Contributor

Resolves #918.

Describe your changes
This changeset addresses Zizmor findings and adds Zizmor to CI.

Testing performed
I ran Zizmor with uvx zizmor .github/ --gh-token=$(gh auth token) --persona=pedantic --fix=all and fixed relevant issues that were not auto-fixable before opening this PR.

Additional context
We also configure Dependabot here to bump Docker image versions. Let me know if this isn't desired.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

tnytown added 3 commits May 18, 2026 11:20
Signed-off-by: Andrew Pan <andrew.pan@trailofbits.com>
Signed-off-by: Andrew Pan <andrew.pan@trailofbits.com>
Signed-off-by: Andrew Pan <andrew.pan@trailofbits.com>
@tnytown
tnytown force-pushed the tnytown/ci-security branch from 186ff88 to 087e0e5 Compare May 18, 2026 18:23
@codecov-commenter

codecov-commenter commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (4a99614) to head (30aa904).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   92.43%   92.39%   -0.04%     
==========================================
  Files          99       99              
  Lines       11785    11785              
  Branches      429      429              
==========================================
- Hits        10893    10889       -4     
- Misses        892      896       +4     
Flag Coverage Δ
cpp 92.39% <ø> (-0.04%) ⬇️
python_and_cython 92.39% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tnytown

tnytown commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

codecov-action seems to support OIDC if you'd like to remove the static secret: https://github.com/codecov/codecov-action#using-oidc

tnytown added 3 commits May 18, 2026 17:25
This workflow is unprivileged, and if this image is compromised there
are bigger problems.

@godlygeek godlygeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tnytown!

@godlygeek
godlygeek enabled auto-merge (squash) May 19, 2026 00:39
@godlygeek
godlygeek merged commit b205e50 into bloomberg:main May 19, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix problems reported by zizmor

4 participants