Skip to content

Conversation

@jugmac00
Copy link
Contributor

No description provided.

@godlygeek
Copy link
Contributor

Thanks! Per our contribution licensing documentation, would you mind adding a Signed-Off-By: tag to your commit message to indicate that you have read and agree to our Developer's Certificate of Origin?

That should be as easy as doing:

$ git commit --amend -C HEAD -s
$ git push -f

from a checkout of this branch.

@jugmac00
Copy link
Contributor Author

@godlygeek Sorrý, must have missed the requirement. -> updated my PR

@godlygeek
Copy link
Contributor

godlygeek commented Apr 21, 2022

OK, sorry, one more thing...

You've made two changes. One of them, to src/memray/_memray/elf_shenanigans.cpp, looks perfectly good and I'm happy to accept it.

The other one is to src/vendor/libbacktrace/ltmain.sh. That file isn't part of Memray's code base, exactly - it's a vendored copy of the libbacktrace code from here: https://github.com/ianlancetaylor/libbacktrace/blob/4d2dd0b172f2c9192f83ba93425f868f2a13c553/ltmain.sh#L570

I'd rather not patch our copy of their code for something so minor as a typo, so I'd like you to remove that change and only make the first one (or I can do that for you, if you'd like).

I'm guessing that even the owners of libbacktrace won't want to accept that change either, because that file seems to be generated code: https://github.com/ianlancetaylor/libbacktrace/blob/4d2dd0b172f2c9192f83ba93425f868f2a13c553/ltmain.sh#L1

That was generated by something in https://git.savannah.gnu.org/cgit/libtool.git/tree/ but as far as I can see that typo no longer exists in the latest version of libtool, so I suspect that this has already been fixed upstream, and just needs to trickle down into other projects over time. https://git.savannah.gnu.org/cgit/libtool.git/tree/bootstrap#n1369 seems like it might be the latest version of that code, and it doesn't contain the typo.

Signed-off-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@jugmac00
Copy link
Contributor Author

Updated once more :-)

@pablogsal pablogsal enabled auto-merge (rebase) April 22, 2022 10:43
@pablogsal
Copy link
Member

Thanks @jugmac00 for your contribution 🎉

@pablogsal pablogsal merged commit 53c8110 into bloomberg:main Apr 22, 2022
@jugmac00 jugmac00 deleted the remove-duplicated-words branch April 22, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants