Add a memray entry point
#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
entry_point
branch
2 times, most recently
from
7940a06 to
7f584fe
Compare
Currently we only have `memray3.X` as an entry point but having also `memray` as an entry point will make it easier for people with only one Python version installed and it would make the usage examples from -h line up with how we actually expect it to be used. This commit also updates the docs and the README file to simplify the examples with the new entry point.
godlygeek
approved these changes
Apr 21, 2022
Contributor
godlygeek
left a comment
godlygeek
left a comment
There was a problem hiding this comment.
LGTM - I removed some no longer needed parentheticals, and spotted a place where we were unnecessarily using implicit string literal concatenation in setup.lpy
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12
Currently we only have
memray3.Xas an entry point but having alsomemrayas an entry point will make it easier for people with only onePython version installed and it would make the usage examples from -h
line up with how we actually expect it to be used.
This commit also updates the docs and the README file to simplify the
examples with the new entry point.