Skip to content

Add more examples to the documentation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godlygeek merged 1 commit into from
Apr 20, 2022
Merged

Add more examples to the documentation #15

godlygeek merged 1 commit into from
Apr 20, 2022

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 19, 2022

Add more example files to the documentation so users can see different
flamegraph files so they can evaluate the tool in different scenarios
that involve native allocations.

@pablogsal pablogsal requested a review from godlygeek April 19, 2022 21:32
@pablogsal pablogsal self-assigned this Apr 19, 2022
@pablogsal pablogsal added the documentation Improvements or additions to documentation label Apr 19, 2022
godlygeek
godlygeek previously approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@godlygeek godlygeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (needed to fix the import order for isort and I fixed up "SQlite" to "SQLite" in one place - and Flake8 doesn't like the variable name l, so I flipped that to lst)

@godlygeek godlygeek enabled auto-merge (rebase) April 20, 2022 03:55
@pablogsal @godlygeek
Add more examples to the documentation
de149b3 
Add more example files to the documentation so users can see different
flamegraph files so they can evaluate the tool in different scenarios
that involve native allocations.
godlygeek
godlygeek approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit ddfcc77 into bloomberg:main Apr 20, 2022
@auxsvr auxsvr mentioned this pull request Jul 28, 2022
Closed
@gnatecheng gnatecheng mentioned this pull request Sep 28, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godlygeek godlygeek godlygeek approved these changes

Assignees

@pablogsal pablogsal

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @godlygeek