This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Fixed bug in blpapi-wrapper.ts for Intraday #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (Intraday vs IntraDay)
lib/blpapi-wrapper.ts
Outdated
Contributor
There was a problem hiding this comment.
Please remove the trailing whitespace here; it is being caught by tslint when TravisCI kicks-off. You can also run make check to run exactly what our CI process executes.
remove trailing whitespace
Author
|
Hmm, pulled the trailing whitespace out but it still seems to be failing. |
Contributor
|
It looks like the tests are failing for some reason. We'll look into this from our end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLPAPI Developer's Guide v2.54 (http://www.bloomberglabs.com/api/content/uploads/sites/2/2014/07/blpapi-developers-guide-2.54.pdf) has incorrect capitalization in table A.2 that propagated into blpapi-wrapper.ts. Corrected this in variable REQUEST_TO_RESPONSE_MAP, enabling correct handling of intraday requests.