Skip to content

Feat: Remove is running on dev #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat: Remove is running on dev #933

wants to merge 6 commits into from

Conversation

bbpetukhov
Copy link
Collaborator

@bbpetukhov bbpetukhov commented Sep 16, 2025 •
edited
Loading

Describe your changes

  • Removed isRunningOnDev field from config
  • Ran codegen to regenerate respective files

** Testing **

  • Checked the source code of an older broker version BMQBRKR_0.93.17. The flag d_isRunningOnDev does not seem to be used anywhere apart from being read from config.
  • Tested old broker version BMQBRKR_0.93.17 using broker config without isRunningOnDev field: ran whole Tests pipeline (including integration tests): https://github.com/bbpetukhov/blazingmq/actions/runs/17790991693

@bbpetukhov bbpetukhov requested a review from a team as a code owner September 16, 2025 08:57
@bbpetukhov
Remove isRunningOnDev from the schema
428aed4 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov
Remove isRunningOnDev from configs; run codegen
38f3181 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov
Upgrade bde version to 4.28
3a9fd92 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov
Add license info to mqbcfg_messages
06105d7 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov
Remove is_running_on_dev in configurator
6da896d 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov
clang-format18
f9865bc 
Signed-off-by: Dmitrii Petukhov <dpetukhov@bloomberg.net>
@bbpetukhov bbpetukhov force-pushed the remove_isRunningOnDev branch from 4717d83 to f9865bc Compare September 16, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bbpetukhov