UT[BMQ]: log default allocations #801

678098 · 2025-06-27T20:18:42Z

[21:29:46] CASE 497: FAILURE (rc -6)
TEST /Users/emalygin/work/blazingmq/src/groups/mqb/mqbs/mqbs_inmemorystorage.t.cpp CASE 497
(0): BloombergLP::bmqtst::LoggingAllocator::allocate(unsigned long)+0x58 at 0x10500b210 in mqbs_inmemorystorage.t
(1): void bsl::shared_ptr<BloombergLP::ntsb::Resolver>::createInplace<BloombergLP::bslma::Allocator*&>(BloombergLP::bslma::Allocator*, BloombergLP::bslma::Allocator*&)+0x4c at 0x105419f98 in mqbs_inmemorystorage.t
(2): BloombergLP::ntsf::System::createResolver(BloombergLP::bslma::Allocator*)+0x5c at 0x105419f14 in mqbs_inmemorystorage.t
(3): BloombergLP::bmqio::ResolveUtil::getHostname(bsl::basic_string<char, std::__1::char_traits<char>, bsl::allocator<char>>*)+0x70 at 0x104ee2568 in mqbs_inmemorystorage.t
(4): BloombergLP::mqbu::MessageGUIDUtil::initialize()+0x9c at 0x104e7e6ec in mqbs_inmemorystorage.t
(5): main+0x444 at 0x104c1ec7c in mqbs_inmemorystorage.t
(6): start+0x17bc at 0x1926cab98 in /usr/lib/dyld

Error /Users/emalygin/work/blazingmq/src/groups/bmq/bmqtst/bmqtst_loggingallocator.cpp(81): false && "The allocation was recorded"    (failed)
libc++abi: terminating due to uncaught exception of type BloombergLP::bsls::AssertTestException

[21:29:46] CASE 498: FAILURE (rc -6)
TEST /Users/emalygin/work/blazingmq/src/groups/mqb/mqbs/mqbs_inmemorystorage.t.cpp CASE 498
(0): BloombergLP::bmqtst::LoggingAllocator::allocate(unsigned long)+0x58 at 0x102e57210 in mqbs_inmemorystorage.t
(1): void bsl::shared_ptr<BloombergLP::ntsb::Resolver>::createInplace<BloombergLP::bslma::Allocator*&>(BloombergLP::bslma::Allocator*, BloombergLP::bslma::Allocator*&)+0x4c at 0x103265f98 in mqbs_inmemorystorage.t
(2): BloombergLP::ntsf::System::createResolver(BloombergLP::bslma::Allocator*)+0x5c at 0x103265f14 in mqbs_inmemorystorage.t
(3): BloombergLP::bmqio::ResolveUtil::getHostname(bsl::basic_string<char, std::__1::char_traits<char>, bsl::allocator<char>>*)+0x70 at 0x102d2e568 in mqbs_inmemorystorage.t
(4): BloombergLP::mqbu::MessageGUIDUtil::initialize()+0x9c at 0x102cca6ec in mqbs_inmemorystorage.t
(5): main+0x444 at 0x102a6ac7c in mqbs_inmemorystorage.t
(6): start+0x17bc at 0x1926cab98 in /usr/lib/dyld

Error /Users/emalygin/work/blazingmq/src/groups/bmq/bmqtst/bmqtst_loggingallocator.cpp(81): false && "The allocation was recorded"    (failed)
libc++abi: terminating due to uncaught exception of type BloombergLP::bsls::AssertTestException

[21:29:46] CASE 499: FAILURE (rc -6)
TEST /Users/emalygin/work/blazingmq/src/groups/mqb/mqbs/mqbs_inmemorystorage.t.cpp CASE 499
(0): BloombergLP::bmqtst::LoggingAllocator::allocate(unsigned long)+0x58 at 0x10267b210 in mqbs_inmemorystorage.t
(1): void bsl::shared_ptr<BloombergLP::ntsb::Resolver>::createInplace<BloombergLP::bslma::Allocator*&>(BloombergLP::bslma::Allocator*, BloombergLP::bslma::Allocator*&)+0x4c at 0x102a89f98 in mqbs_inmemorystorage.t
(2): BloombergLP::ntsf::System::createResolver(BloombergLP::bslma::Allocator*)+0x5c at 0x102a89f14 in mqbs_inmemorystorage.t
(3): BloombergLP::bmqio::ResolveUtil::getHostname(bsl::basic_string<char, std::__1::char_traits<char>, bsl::allocator<char>>*)+0x70 at 0x102552568 in mqbs_inmemorystorage.t
(4): BloombergLP::mqbu::MessageGUIDUtil::initialize()+0x9c at 0x1024ee6ec in mqbs_inmemorystorage.t
(5): main+0x444 at 0x10228ec7c in mqbs_inmemorystorage.t
(6): start+0x17bc at 0x1926cab98 in /usr/lib/dyld

Error /Users/emalygin/work/blazingmq/src/groups/bmq/bmqtst/bmqtst_loggingallocator.cpp(81): false && "The allocation was recorded"    (failed)
libc++abi: terminating due to uncaught exception of type BloombergLP::bsls::AssertTestException

678098 · 2025-06-27T20:19:14Z

src/groups/bmq/bmqma/bmqma_countingallocator.cpp

+    if (d_parentCounting_p) {
+        d_parentCounting_p->onAllocationChange(deltaValue);
+    }
+}


Moved to MANIPULATORS

678098 · 2025-06-27T20:23:05Z

src/groups/bmq/bmqtst/package/bmqtst.mem

@@ -1,3 +1,4 @@
 bmqtst_blobtestutil
+bmqtst_loggingallocator


bmqtst doesn't depend on bmqma, andI don't want introduce this dependency by placing LoggingAllocator there

bmq-oss-ci

Build 2819 of commit 15687c5 has completed with FAILURE

bmq-oss-ci

Build 2839 of commit 5a07cb4 has completed with FAILURE

hallfox · 2025-07-08T20:39:27Z

src/groups/bmq/bmqtst/bmqtst_loggingallocator.cpp

+        if (d_failFast) {
+            BSLS_ASSERT_OPT(false && "The allocation was recorded");
+        }


In theory BSLS_ASSERT_OPT is not guaranteed to be enabled in every build, it's probably more appropriate to call std::terminate here if that's what was intended.

Good point! Alternatively, what about raising an exception?

We cannot raise exceptions in this code by policy. Oddly enough I don't think we document that policy anywhere! But we do not allow exceptions to be thrown in bmq, mqb, or bmqbrkr code.

Currently, any assert statement generates an exception that causes termination of the program if not handled.

libc++abi: terminating due to uncaught exception of type BloombergLP::bsls::AssertTestException

hallfox · 2025-07-08T20:41:25Z

src/groups/bmq/bmqtst/bmqtst_loggingallocator.h

+    /// @brief Check whether the undesired allocations were recorded and raise
+    ///        an exception if any.
+    void checkNoAllocations();


This doesn't raise an exception if it fails, rather it just ASSERTs. I think it would be better to return !d_failed.load() and have the caller check for the failure.

bmq-oss-ci

Build 2870 of commit f138283 has completed with FAILURE

bmq-oss-ci

Build 2878 of commit 064d39a has completed with FAILURE

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

678098 requested a review from a team as a code owner June 27, 2025 20:18

678098 commented Jun 27, 2025

View reviewed changes

678098 force-pushed the 250627_log_default_allocation branch from 54f35d0 to e493b40 Compare June 27, 2025 20:21

678098 commented Jun 27, 2025

View reviewed changes

678098 force-pushed the 250627_log_default_allocation branch from e493b40 to 04c852b Compare June 27, 2025 20:49

678098 requested a review from dorjesinpo June 27, 2025 20:49

678098 assigned dorjesinpo Jun 27, 2025

dorjesinpo previously approved these changes Jun 27, 2025

View reviewed changes

678098 dismissed dorjesinpo’s stale review via 15687c5 June 27, 2025 22:32

678098 force-pushed the 250627_log_default_allocation branch from 04c852b to 15687c5 Compare June 27, 2025 22:32

bmq-oss-ci bot reviewed Jun 28, 2025

View reviewed changes

678098 force-pushed the 250627_log_default_allocation branch from 15687c5 to 5a07cb4 Compare July 7, 2025 16:12

bmq-oss-ci bot reviewed Jul 7, 2025

View reviewed changes

hallfox reviewed Jul 8, 2025

View reviewed changes

678098 force-pushed the 250627_log_default_allocation branch from 5a07cb4 to f138283 Compare July 9, 2025 09:29

bmq-oss-ci bot reviewed Jul 9, 2025

View reviewed changes

678098 force-pushed the 250627_log_default_allocation branch from f138283 to 064d39a Compare July 10, 2025 15:49

bmq-oss-ci bot reviewed Jul 10, 2025

View reviewed changes

UT[BMQ]: log default allocations

ffd4530

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

678098 force-pushed the 250627_log_default_allocation branch from 064d39a to ffd4530 Compare July 30, 2025 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UT[BMQ]: log default allocations #801

UT[BMQ]: log default allocations #801

Uh oh!

678098 commented Jun 27, 2025 •

edited

Loading

Uh oh!

678098 Jun 27, 2025

Uh oh!

678098 Jun 27, 2025

Uh oh!

bmq-oss-ci bot left a comment

Uh oh!

bmq-oss-ci bot left a comment

Uh oh!

hallfox Jul 8, 2025

Uh oh!

678098 Jul 9, 2025

Uh oh!

hallfox Jul 15, 2025

Uh oh!

678098 Jul 21, 2025

Uh oh!

hallfox Jul 8, 2025

Uh oh!

bmq-oss-ci bot left a comment

Uh oh!

bmq-oss-ci bot left a comment

Uh oh!

Uh oh!

UT[BMQ]: log default allocations #801

Are you sure you want to change the base?

UT[BMQ]: log default allocations #801

Uh oh!

Conversation

678098 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

678098 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

678098 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

Uh oh!

bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

Uh oh!

hallfox Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

678098 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

hallfox Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

678098 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

hallfox Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

Uh oh!

bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

678098 commented Jun 27, 2025 •

edited

Loading