Conversation
Flaky tests should not prevent sanitizers from running. Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
678098
changed the title
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
pniedzielski
left a comment
pniedzielski
left a comment
There was a problem hiding this comment.
Maybe we need to consider consolidating the number of places and ways we build BDE and NTF. We sort of did this with build-ubuntu.yaml, but the prometheus build, build-ubuntu.sh, and build-darwin.sh have similar issues.
docker/sanitizers/build_sanitizer.sh
Outdated
| --without-warnings-as-errors \ | ||
| --without-usage-examples \ | ||
| --without-applications \ | ||
| --with-zlib \ |
There was a problem hiding this comment.
This doesn't really matter, but if we do it we should make it true across every place we build NTF in the repo (and Python SDK too), since that inconsistency was the source of the bug this PR fixes. I'd rather just keep it as is, no harm no foul.
There was a problem hiding this comment.
I think we never use ntf-core level traffic compression, so it is not necessary to build it with zlib or any other compression library. We use zlib to compress payload before sending it to ntc
| --without-zlib \ | ||
| --without-zstd \ | ||
| --without-lz4 \ | ||
| --without-openssl \ |
There was a problem hiding this comment.
Same here. Core issue of this PR was the build flags are different across every place we build NTF, and we missed one place. I think we should update everywhere to be the same if we update; or we should install openssl-dev everywhere.
2 participants
No description provided.