Skip to content

Perf: concrete mqbi::DispatcherEvent events#1116

Open
678098 wants to merge 1 commit intobloomberg:mainfrom
678098:260213_dispatcher_event_inheritance
Open

Perf: concrete mqbi::DispatcherEvent events#1116
678098 wants to merge 1 commit intobloomberg:mainfrom
678098:260213_dispatcher_event_inheritance

Conversation

@678098
Copy link
Collaborator

@678098 678098 commented Feb 13, 2026 •
edited
Loading

Benchmarks

Linux x86_64

Before:

Name                  | sizeof | constructor, ns/op
---------------------------------------------------
mqbi::DispatcherEvent |    768 |            46.6131

After:

                       Name | sizeof | constructor, ns/op | reset (ns/op)
=========================================================================
           mqbevt::AckEvent |     96 |           6.145480 |      3.668200
      mqbevt::CallbackEvent |     64 |           6.136220 |      2.279000
  mqbevt::ClusterStateEvent |     48 |           5.440250 |      2.329530
       mqbevt::ConfirmEvent |     72 |           6.136910 |      3.357720
mqbevt::ControlMessageEvent |    208 |           9.437210 |      4.473490
    mqbevt::DispatcherEvent |    104 |           8.259750 |      2.133980
          mqbevt::PushEvent |    256 |          17.632800 |      5.508160
           mqbevt::PutEvent |    136 |           6.687370 |     12.936720
       mqbevt::ReceiptEvent |     48 |           5.165990 |      1.826960
      mqbevt::RecoveryEvent |     48 |           5.702260 |      2.432480
        mqbevt::RejectEvent |     80 |           5.820400 |      3.038740
       mqbevt::StorageEvent |     48 |           6.152550 |      2.431490

Mac M2

Before:

Name                  | sizeof | constructor, ns/op 
---------------------------------------------------
mqbi::DispatcherEvent |    768 |             197.51

After:

                       Name | sizeof | constructor, ns/op | reset (ns/op)
=========================================================================
           mqbevt::AckEvent |     96 |          19.357500 |      9.600840
      mqbevt::CallbackEvent |     64 |          25.825420 |      5.437500
  mqbevt::ClusterStateEvent |     48 |          12.276250 |      5.537080
       mqbevt::ConfirmEvent |     72 |          13.469590 |      7.685420
mqbevt::ControlMessageEvent |    208 |          35.178330 |     17.594170
    mqbevt::DispatcherEvent |    104 |          34.957500 |      7.789590
          mqbevt::PushEvent |    256 |          65.809580 |     26.294170
           mqbevt::PutEvent |    136 |          52.033750 |     47.957500
       mqbevt::ReceiptEvent |     48 |           9.312500 |      4.004170
      mqbevt::RecoveryEvent |     48 |           8.900420 |      4.003750
        mqbevt::RejectEvent |     80 |          10.410410 |      5.669160
       mqbevt::StorageEvent |     48 |           8.735410 |      4.276250

@678098 678098 requested a review from a team as a code owner February 13, 2026 21:42
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch from a2689f8 to f132bff Compare February 18, 2026 17:24
@678098 678098 changed the title wip: Perf: fix mqbi::DispatcherEvent inheritance, event sources per event type Perf: fix mqbi::DispatcherEvent inheritance, event sources per event type Feb 18, 2026
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch from 5333fc9 to e227be8 Compare February 18, 2026 21:20
@678098 678098 changed the title Perf: fix mqbi::DispatcherEvent inheritance, event sources per event type Perf: invert mqbi::DispatcherEvent inheritance Feb 18, 2026
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch 5 times, most recently from 26a6afd to 78775ae Compare February 20, 2026 17:24
@678098 678098 changed the title Perf: invert mqbi::DispatcherEvent inheritance Perf: concrete mqbi::DispatcherEvent events Feb 20, 2026
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch 5 times, most recently from ade84c9 to 28ee596 Compare February 27, 2026 20:50
@678098 678098 mentioned this pull request Mar 4, 2026
Closed
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch 3 times, most recently from 31c28f6 to 4c94ab6 Compare March 19, 2026 16:08
@678098
Perf: concrete dispatcher events
d62ea70 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098 678098 force-pushed the 260213_dispatcher_event_inheritance branch from 4c94ab6 to d62ea70 Compare March 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@678098