Private named static fields#33
Closed
mheiber wants to merge 2 commits intobloomberg:es-private-fieldsfrom
Closed
Conversation
Transform private-named instance methods Signed-off-by: Max Heiber <max.heiber@gmail.com>
Implement transformation for private-named fields. This turned out to be as easy as ignoring whether a private-named field is static or not. Signed-off-by: Max Heiber <max.heiber@gmail.com>
mheiber
force-pushed
the
private-named-static-fields
branch
from
21e2f6a to
bdc8a55
Compare
mheiber
changed the base branch from
es-private-fields
to
private-named-instance-fields
mheiber
changed the base branch from
private-named-instance-fields
to
es-private-fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 meaningful commit, so please check the diff there
Builds on #19
which builds on #32
The emit seems like it might be right, even though all I did was update the code related to emitting private names for fields so that it doesn't pay attention to whether the field is static or not.