Accounts support #327
Merged
Accounts support #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llbacks for accounts
godmodegalactus
force-pushed
the
accounts_support
branch
from
543e39b to
0ec2521
Compare
| broadcast::channel::<AccountNotificationMessage>(128); | ||
|
|
||
| let jh: AnyhowJoinHandle = tokio::spawn(async move { | ||
| loop { |
There was a problem hiding this comment.
reconnect loops should always be throttled to prevent overloading the system with crash-loop
| }) | ||
| } | ||
|
|
||
| pub fn create_grpc_account_streaming( |
There was a problem hiding this comment.
pls comment somewhere how much RAM an "account" item requires
| match update { | ||
| UpdateOneof::Account(account) => { | ||
| if let Some(account_data) = account.account { | ||
| let account_pk_bytes: [u8; 32] = account_data |
There was a problem hiding this comment.
consider different abbreviation for pubkey in account_pk; maybe account_key or account_pubkey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.