Improvement/check block sequencing #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godmodegalactus
previously approved these changes
Jan 22, 2024
|
Fix conflicts and clippy |
godmodegalactus
requested changes
Feb 7, 2024
| if block.commitment_config.is_processed() { | ||
| let prev_value = | ||
| saw_processed_at.insert(blockhash.clone(), (slot, SystemTime::now())); | ||
| match prev_value { |
There was a problem hiding this comment.
replace it with if let Some(prev) = ...
| if block.commitment_config.is_confirmed() { | ||
| let prev_value = | ||
| saw_confirmed_at.insert(blockhash.clone(), (slot, SystemTime::now())); | ||
| match prev_value { |
| let prev_value = | ||
| saw_finalized_at.insert(blockhash.clone(), (slot, SystemTime::now())); | ||
| match prev_value { | ||
| None => { |
|
|
||
| // rule: if confirmed, we should have seen processed but not finalized | ||
| if block.commitment_config.is_confirmed() { | ||
| if saw_processed_at.contains_key(&blockhash) { |
There was a problem hiding this comment.
Same here should be like .is_none()
| } else { | ||
| warn!("should not see confirmed slot without seeing processed slot first ({})", blockhash); | ||
| } | ||
| if saw_finalized_at.contains_key(&blockhash) { |
| "should not see confirmed slot after seeing finalized slot ({})", | ||
| blockhash | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
remove else, no need to add more code for comments.
lite-rpc/src/main.rs
Outdated
| @@ -164,6 +162,17 @@ pub async fn start_lite_rpc(args: Config, rpc_client: Arc<RpcClient>) -> anyhow: | |||
| vote_account_notifier, | |||
| } = subscriptions; | |||
|
|
|||
| // note: check failes for commitment_config processed because sources might disagree on the blocks | |||
| debugtask_blockstream_slot_progression( | |||
There was a problem hiding this comment.
Should be optional.
godmodegalactus
previously approved these changes
Feb 7, 2024
|
hide grpc_inspect behind flag |
godmodegalactus
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: requires a not-yet-published version of geyser-grpc-connector (open PR); unfortunately lite-rpc and geyser-grpc-connector depend in turn on an unpublished version of geyser-grpc-connection crate! keep the git pointer for now
Configuration:
Adds parameter
enable_grpc_stream_inspectionto configExtensive Test on solana-lite-rpc-staging against testnet:
the message
block sequence seenis produces when the artificial consumer was able to receive three full-blocks in correct order and without duplicates