Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-131: Increase tmax #8

Closed
wants to merge 1 commit into from

Conversation

PavloMalashnyak
Copy link
Collaborator

@PavloMalashnyak PavloMalashnyak commented Dec 5, 2023

Copy link

@zhongshixi zhongshixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PavloMalashnyak we could not set the tmax via the pbjs configuration? i thought our client script should set the tmax value instead of hard code the tmax value in the adapter

Copy link

@zhongshixi zhongshixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PavloMalashnyak do you happen to know for the value 2000, where they come from?

Screenshot 2023-12-05 at 2 00 49 PM __

@PavloMalashnyak
Copy link
Collaborator Author

PavloMalashnyak commented Dec 6, 2023

@PavloMalashnyak we could not set the tmax via the pbjs configuration? i thought our client script should set the tmax value instead of hard code the tmax value in the adapter

There are 2 other way to set it that I know of. We can pass it while calling requestBids or set bidderTimeout config, but that would set tmax for all bidder that take part in an auction. Setting bidderTimeout using setBidderConfig won't change tmax, since prebid uses its global value.
Instead of hardcoding it we could do smth like request.tmax = config.getConfig('bidderTimeout') || 2000 while setting bidderTimeout in bidderConfig. Or if this is caused by additional time we need to call /tc we can move this logic to our prebid.js build

@PavloMalashnyak do you happen to know for the value 2000, where they come from?

We set it to that in client script for all bidders

PavloMalashnyak pushed a commit that referenced this pull request Mar 4, 2024
* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (#13)

* [RPO-3262] Update getUid function to check for pubcid and sharedid (#14)

* Update getUid function to check for pubcid and sharedid

* updates adapter version

* [RPO-3405] Add browserLanguage to request meta object

* ConcertBidAdapter: Add TDID (prebid#20)

* Add tdid to meta object

* Fix null handling and add tests

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
Co-authored-by: Brett Bloxom <38990705+BrettBlox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants