Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve categorization of smart-contracts' methods #4641

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Sep 13, 2021

Close #4557

Changelog

Bug fixes:

  • Fix impossibility to query read methods of proxy smart contracts (not its implementation)

Enhancements

  • Improve things was done in Hide error selector in the contract's functions list #4612
  • Duplicate methods stateMutability=nonpayable methods with at least one output the Read Contract page
  • Add wallet connection section to Read Contract page if there are stateMutability=nonpayable methods with at least one output
  • Add field from to the eth_call for aforementioned methods

Checklist for your Pull Request (PR)

@nikitosing nikitosing changed the title Np add subclass of read methods Improve categorization of smart-contracts' methods Sep 13, 2021
@nikitosing nikitosing force-pushed the np-add-subclass-of-read-methods branch 2 times, most recently from fc56523 to aa6a799 Compare September 14, 2021 20:00
@nikitosing nikitosing requested a review from vbaranov September 14, 2021 20:00
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitosing I suppose, differentiating read-only methods with modifiers as methods that have no input parameters and have output parameters is wrong. At least, because, read-only method with modifiers can accept input parameters as well. In that case, it is hard or impossible to differentiate the read-only method with modifier and wite method. Let's discuss this internally.

@nikitosing nikitosing force-pushed the np-add-subclass-of-read-methods branch 7 times, most recently from 1ac5d32 to a8cb3f5 Compare September 19, 2021 19:01
@nikitosing nikitosing requested a review from vbaranov September 19, 2021 19:01
@nikitosing nikitosing force-pushed the np-add-subclass-of-read-methods branch 2 times, most recently from 7802127 to 6e54bdd Compare September 20, 2021 16:33
@nikitosing nikitosing force-pushed the np-add-subclass-of-read-methods branch from 6e54bdd to 8274e5d Compare September 21, 2021 10:37
@nikitosing nikitosing requested a review from vbaranov September 21, 2021 10:38
@vbaranov vbaranov merged commit 8e1b551 into master Sep 21, 2021
@vbaranov vbaranov deleted the np-add-subclass-of-read-methods branch September 21, 2021 16:31
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Sep 21, 2021
…-read-methods

 Improve categorization of smart-contracts' methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read methods with modifiers are shown as Write methods
2 participants