Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR code tooltip appearance in mobile view #3509

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 3, 2020

Motivation

Fix QR code tooltip appearance in mobile view
Screenshot 2020-12-03 at 23 04 37

The tooltip shouldn't appear in the mobile view

Changelog

Manage the appearance of tooltip through Javascript

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-fix-qr-tooltip-appearance branch from 699412e to 58e5b2b Compare December 3, 2020 20:07
@vbaranov vbaranov force-pushed the vb-fix-qr-tooltip-appearance branch from 58e5b2b to fb72a2e Compare December 3, 2020 20:29
@coveralls
Copy link

coveralls commented Dec 3, 2020

Pull Request Test Coverage Report for Build fb72a2ec14a82fcb12a6e680df8d9beefff41d25-PR-3509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 66.764%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build ad2a5ea1745436ff3beef07eba276e73ae140810: 0.1%
Covered Lines: 2063
Relevant Lines: 3090

💛 - Coveralls

@vbaranov vbaranov merged commit 3f9f0e8 into master Dec 3, 2020
@vbaranov vbaranov deleted the vb-fix-qr-tooltip-appearance branch December 3, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants