Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for tx input #2808

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add tooltip for tx input #2808

merged 2 commits into from
Oct 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 28, 2019

Motivation

Missing tooltip on tx input Copy button

Changelog

Screenshot 2019-10-28 at 15 43 01

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Oct 28, 2019
@vbaranov vbaranov force-pushed the vb-tx-input-missing-tooltip branch from 886c467 to 440593b Compare October 28, 2019 12:49
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Oct 28, 2019
@vbaranov vbaranov requested review from pasqu4le and ayrat555 October 28, 2019 12:55
@coveralls
Copy link

coveralls commented Oct 28, 2019

Pull Request Test Coverage Report for Build d1cccc31-a4e8-49a8-b384-380f9c651a36

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 76.611%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token.ex 1 80.0%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.88%
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
apps/indexer/lib/indexer/block/fetcher.ex 4 86.75%
apps/indexer/lib/indexer/fetcher/token_instance.ex 4 0.0%
Totals Coverage Status
Change from base Build 5a34f4b0-f9e1-41c3-a00b-ad47a04e51c0: -0.2%
Covered Lines: 5290
Relevant Lines: 6905

💛 - Coveralls

@vbaranov vbaranov marked this pull request as ready for review October 28, 2019 12:57
@vbaranov vbaranov merged commit e4696d7 into master Oct 29, 2019
@vbaranov vbaranov deleted the vb-tx-input-missing-tooltip branch October 29, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants