Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render a nicer error when creator cannot be determined #1534

Merged
merged 2 commits into from
Mar 13, 2019
Merged

fix: render a nicer error when creator cannot be determined #1534

merged 2 commits into from
Mar 13, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Mar 6, 2019 •
edited
Loading

Part of #1503

Motivation

  • To start off with, we should have a nicer error case when this happens. It makes it easier to debug, and also makes the problem less annoying for users, if determining the root cause takes a while.

Changelog

Bug Fixes

  • Don't show internal server error page when a contract creator cannot be determined.

Screen Shot 2019-03-12 at 09 42 27

@ghost ghost assigned zachdaniel Mar 6, 2019
@ghost ghost added the in progress label Mar 6, 2019
@zachdaniel zachdaniel force-pushed the clean-up-contract-error-message branch from 7d087ea to 04bb096 Compare March 6, 2019 16:31
@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2e5c65f4-b30b-42de-aef8-230dfb42e782

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 84.49%
Totals Coverage Status
Change from base Build cb73ea85-f6fb-4e60-9c9f-6ab6e48697c9: 0.2%
Covered Lines: 4298
Relevant Lines: 5087
💛 - Coveralls

@zachdaniel zachdaniel force-pushed the clean-up-contract-error-message branch from 04bb096 to 97d8d4a Compare March 11, 2019 13:45
vbaranov
vbaranov reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachdaniel could you resolve merging conflicts and attach the screenshot with the message?

@zachdaniel zachdaniel force-pushed the clean-up-contract-error-message branch from 97d8d4a to d5dc6a3 Compare March 12, 2019 13:36
@zachdaniel
Copy link
Contributor Author

@vbaranov done

@zachdaniel zachdaniel requested a review from ayrat555 March 12, 2019 13:43
@ghost ghost assigned vbaranov Mar 13, 2019
@vbaranov vbaranov self-requested a review March 13, 2019 08:33
vbaranov
vbaranov approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, what network is the contract from the screenshot from? I found a contract with an address from the screenshot in Sokol network, but the creator is displayed for it (in Sokol production)

@zachdaniel
Copy link
Contributor Author

@vbaranov it is from Sokol, but I just altered the data locally to show the feature since it takes a long time to query to find one of these.

@vbaranov vbaranov merged commit f92e6b2 into master Mar 13, 2019
@ghost ghost removed the in progress label Mar 13, 2019
@vbaranov vbaranov deleted the clean-up-contract-error-message branch March 13, 2019 13:16
@zachdaniel zachdaniel mentioned this pull request Apr 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@vbaranov vbaranov vbaranov approved these changes

Assignees

@vbaranov vbaranov

@zachdaniel zachdaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zachdaniel @coveralls @vbaranov @ayrat555