-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user-ops-indexer): support entrypoint v08 #1296
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for entrypoint v08 by updating proto definitions, migration scripts, and indexer logic to handle multiple entry points. Key changes include:
- Updating proto messages and field names (renaming v07 to v07_v08) and deprecating raw user op messages.
- Adding a new migration (m20250326_080441_entrypoint_v08.rs) to update the entrypoint type.
- Refactoring indexer logic and settings to support vectors of entrypoint addresses for v06, v07, and v08.
Reviewed Changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
user-ops-indexer-proto/proto/user-ops-indexer.proto | Renamed field and updated proto definitions to support entrypoint v08. |
user-ops-indexer-proto/build.rs | Added extern path for google.protobuf types. |
user-ops-indexer-proto/Cargo.toml | Included prost-wkt dependencies. |
user-ops-indexer-migration | Added migration script for v08 and updated migrator. |
user-ops-indexer-logic/src/types/user_op.rs | Updated raw user op conversion to use JSON instead of oneof. |
user-ops-indexer-logic (v07, v06, base_indexer, settings, status, rpc_utils, tests) | Refactored indexer logic for multi-entrypoint support and updated tests accordingly. |
user-ops-indexer/README.md | Updated environment variable documentation to include v08 settings. |
Files not reviewed (3)
- user-ops-indexer/user-ops-indexer-logic/src/indexer/tests/fixtures/handle_tx_v06_ok.json: Language not supported
- user-ops-indexer/user-ops-indexer-logic/src/indexer/tests/fixtures/handle_tx_v07_ok.json: Language not supported
- user-ops-indexer/user-ops-indexer-logic/src/indexer/tests/fixtures/handle_tx_v08_ok.json: Language not supported
Comments suppressed due to low confidence (1)
user-ops-indexer/user-ops-indexer-proto/proto/user-ops-indexer.proto:127
- [nitpick] The field name 'v07_v08' could be ambiguous; consider renaming it to more explicitly reflect its purpose (e.g., 'v07_and_v08') or provide additional documentation to clarify its meaning.
EntryPointIndexerStatus v07_v08 = 3;
No description provided.