Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bens): add configs for indexing names from puppynet #1187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(bens): add configs for indexing names from puppynet #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions blockscout-ens/bens-server/config/dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,18 @@
"url": "https://shibariumscan.io"
},
"use_protocols": [
"d3_connect"
"d3_connect_shib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Protocol rename is incomplete and inconsistent

The protocol rename from "d3_connect" to "d3_connect_shib" is not consistently applied. Found multiple instances still using the old name:

  • In dev.json: Two configurations using "type": "d3_connect"
  • In prod.json: Network 109 configuration still uses "d3_connect" in protocol list and configuration object
🔗 Analysis chain

Verify protocol rename consistency across the codebase.

The protocol rename from "d3_connect" to "d3_connect_shib" should be reflected in all related configurations and code.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old protocol name
rg "d3_connect\"" --type json

Length of output: 389

Script:

#!/bin/bash
# Get context around d3_connect occurrences
echo "=== dev.json ==="
rg -B 2 -A 2 "d3_connect\"" blockscout-ens/bens-server/config/dev.json

echo -e "\n=== prod.json ==="
rg -B 2 -A 2 "d3_connect\"" blockscout-ens/bens-server/config/prod.json

Length of output: 1252

],
"rpc_url": "https://www.shibrpc.com"
},
"157": {
"blockscout": {
"url": "https://puppyscan.shib.io/"
},
"use_protocols": [
"d3_connect_shib_testnet"
],
"rpc_url": "https://puppynet.shibrpc.com"
}
},
"protocols": {
Expand Down Expand Up @@ -69,7 +78,7 @@
"docs_url": "https://docs.ens.domains/"
}
},
"d3_connect": {
"d3_connect_shib": {
"tld_list": ["shib"],
"network_id": 109,
"subgraph_name": "d3-connect-shib-subgraph",
Expand All @@ -86,6 +95,24 @@
"icon_url": "https://i.imgur.com/cD6VIXk.png",
"docs_url": "https://docs.d3.app/"
}
},
"d3_connect_shib_testnet": {
"tld_list": ["shib"],
"network_id": 157,
"subgraph_name": "d3-connect-shib-subgraph",
"address_resolve_technique": "reverse_registry",
"specific": {
"type": "d3_connect",
"native_token_contract": "0x4F3775dfd49db0BBcd47eB6f45CEb6E6E9e15CD8",
"resolver_contract": "0x51B4894B45A764d2bF48aE5D7F9e70Ac70e28875"
},
"meta": {
"short_name": "D3 Connect",
"title": "D3 Connect",
"description": "D3 Connect is a platform for connecting to the Shibarium network.",
"icon_url": "https://i.imgur.com/cD6VIXk.png",
"docs_url": "https://docs.d3.app/"
}
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions blockscout-ens/graph-node/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,9 @@ provider = [
{ label = "shibarium", url = "https://www.shibrpc.com", features = [] }
]
shard = "primary"

[chains.shibarium-testnet]
provider = [
{ label = "shibarium-testnet", url = "https://puppynet.shibrpc.com", features = [] }
]
shard = "primary"
5 changes: 5 additions & 0 deletions blockscout-ens/graph-node/deployer/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@
"subgraph_path": "../subgraphs/d3-connect-subgraph",
"subgraph_name": "d3-connect-shib-subgraph",
"network": "shibarium"
},
"d3-connect-shib-testnet": {
"subgraph_path": "../subgraphs/d3-connect-subgraph",
"subgraph_name": "d3-connect-shib-subgraph",
"network": "shibarium-testnet"
}
}
}