feat: improve validation and error handling #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when specificed Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
segunjkf
changed the title
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
Signed-off-by: segunjkf <sege.timz12@gmail.com>
segunjkf
changed the title
| </p> | ||
|
|
||
| <h1 align="center">Blocks</h1> | ||
| <h1 align="center">BlocksOp Network</h1> |
| Enable both metrics and logs: | ||
|
|
||
| ```bash | ||
| agent \ |
Contributor
There was a problem hiding this comment.
the binary name should be telescope
| Create a YAML configuration file and run: | ||
|
|
||
| ```bash | ||
| agent --config-file=telescope_config.yaml |
Contributor
There was a problem hiding this comment.
please update the binary name here as well
| "sort" | ||
| "strings" | ||
|
|
||
| networksConfig "github.com/grafana/agent/internal/static/config/networks" |
Contributor
There was a problem hiding this comment.
we need this to point to our own repo not grafana's, can you make the update in the go.mod file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist