-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - New Font Usage (Inter) and Dynamic Font Handling #1597
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a console log to be removed and a question around the check if a font has been defined.
Also where is the dynamic loading occurring? It all looks like it is imported regardless of configuration from what I can tell?
Co-authored-by: Aaron <abarnard@protonmail.com>
Refactored and moved to the CDN approach as recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in the demo with useWebFont: true and passing custom font via --w3o-font-family
…ative/onboard into feature/dynamic_fonts
Description
Notion card with stats and pictures
Option to define a font through either the new theme property
--w3o-font-family
or the legacy css font var--onboard-font-family-normal
Or set
useWebFont
to true and use the default fallbacksans-serif
font by settingType changes:
Add
'--w3o-font-family'
Theme
prop:Add
useWebFont
boolean prop to init options:Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errors