4.5.0-0.1.0: [feature] - Optional dappId when apiUrl#202
Merged
Conversation
Adamj1232
approved these changes
Aug 4, 2022
Adamj1232
left a comment
Contributor
There was a problem hiding this comment.
Nice! Does any documentation need to be added around this change?
taylorjdawson
approved these changes
Aug 4, 2022
mahmud-bn
approved these changes
Aug 4, 2022
Collaborator
Author
|
@Adamj1232 Yes there will be documentation changes needed, but we are waiting on the implementation on the server to define the name of the query parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Blocknative server now allows authentication with an API key as a query parameter in the initial http upgrade request rather than needing to pass the API key as the
dappIdparameter within the initial message. This can be useful in the case of using a WebSocket proxy to hide the API key.This PR changes the types so that the either a
dappIdor aapiUrlneeds to be passed in to initialization and assumes that the API key is included in theapiUrlas a query parameter.Checklist
package.jsonis incremented following semantic versioning