Feature/tx timestamp #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 15, 2021 15:22
At Chris's request, adding full transactions instead of hashes in the custom mempool feeds. Additionally, I've added timestamps in nano-seconds for when each message is emitted.
p2pts indicates the timestamp of when a transaction was first received by the p2p subsystem, prior to being validated.
|
I can roll back the newHeadsWithPeers if it's not wanted, but it was super easy to do and would have very minimal performance implications, so I thought it might plausibly be useful. |
AusIV
pushed a commit
that referenced
this pull request
Jun 21, 2021
…er (#7) (ethereum#22989) Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a p2pts for both newPendingTransactionsWithPeers and newHeadsWithPeers, which indicates when those items were received by the peer-to-peer subsystems, before they were validated.
Note that this PR is on top of #6, which has not currently been merged.