Custom notifications #133
Merged
Custom notifications #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow specifying custom timeouts for notifications
- Validate userInitiatedNotify arguments
- Improve customNotify test suite
cmeisl
reviewed
May 9, 2019
cmeisl
added a commit
that referenced
this pull request
May 9, 2019
* scroll container now scrolls to bottom when new notification is added (#151) * Create contract tests & improve stability with new web3js versions (#149) * Test contract decoration matches snapshot * Update yarn.lock * Improve Contract test coverage * Classify existing Contract tests as unit tests * Run contract tests with multiple web3 versions * Clear localStorage between contract tests * Improve comment * Remove redundant comment * Mock websocket in contract test * Remove mock-socket from contract tests * Only snapshot test a subset of decoratedContract * Remove redundant logic * Mock the web3 websocket connection * Cleanup * Use a complex ABI for contract decoration tests * Refactor contract delegation for web3 >beta.37 * Improve comments * Hardcode userAgent in tests * Custom notifications (#133) * - Allow user to spawn custom notifications - Allow specifying custom timeouts for notifications * - Improve userInitiatedNotify func name - Validate userInitiatedNotify arguments * Check assist is ready for userInitiatedNotify * Remove options param from userInitiatedNotify * Move notify method to assistInstance * Add notity docs * Improve notify docs * Improve comment * Don't call setHeight when no notifications * Fix userInitiatedNotify validation * Improve docs * Fix notify function signature in docs * Improve notify docs example * Improve import syntax * Test for a potential difficult to detect bug * Fix notify customTimeout not working sometimes * Mention HMTL can be embedded in customNotify msgs * Show timer in custom "pending" notification * Add ui-rendering tests for custom notify events * Test that customTimeout works * Specify notify customTimeout in an options object * - Fix customNotify bug - Improve customNotify test suite * Specify customTimeout type * Log custom events to the server * Improve test * Update yarn.lock * Improve tests * Improve comment * Validate customCode * Limit customCode to 24 characters * Improve user-initiated-notify tests * Increase test run speed * Improve customCode default * change eventCode for custom notification * Add updateStyle function (#145) * Create updateStyle method * Add updateStyle docs * Allow updating notificationsPosition * Test updating notifPos doesn't throw an error * Update notify docs * Improve comments * Enhancement/onboard returns state (#152) * onboard returns current user state upon completion * fixed tests * remove describe statement * remove test.only * update to 0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114
customTimeoutparam to notificationUI eventsTODO:
-1customTimeoutinto an options param