-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/metadata errors #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/metadata errors #417
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8c43ba9 to
19e8ffa
Compare
19e8ffa to
bbf71a9
Compare
bbf71a9 to
b3c3ea8
Compare
b3c3ea8 to
4ed667e
Compare
4ed667e to
7d05677
Compare
7d05677 to
a503206
Compare
a503206 to
bb90d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds error reporting functionality for metadata fetching failures by exposing structured error information when off-chain metadata cannot be fetched or validated. The change enables API consumers to understand why metadata retrieval failed and handle errors appropriately.
Key changes:
- Added optional
errorobject to metadata schemas with standardized error codes and human-readable messages - Updated TypeScript type definitions to reflect the new error field
- Added comprehensive test coverage for the new error structure
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/schemas/pools/pool_metadata.yaml | Added error object schema to pool metadata |
| src/schemas/pools/pool_list_extended.yaml | Added error object schema to extended pool list metadata |
| src/schemas/governance/proposal_metadata_v2.yaml | Added error object schema to governance proposal metadata |
| src/generated-types.ts | Updated TypeScript interfaces with optional error field |
| openapi.yaml | Updated OpenAPI specification with error object definitions |
| openapi.json | Updated JSON OpenAPI specification with error object definitions |
| docs/blockfrost-openapi.yaml | Updated documentation OpenAPI specification |
| blockfrost-openapi.yaml | Updated public OpenAPI specification |
| test/tests/get-schema-for-endpoint.test.ts | Added test coverage for error object schema and fixed quote consistency |
| test/tests/snapshots/get-schema-for-endpoint.test.ts.snap | Updated test snapshots to include error object |
| CHANGELOG.md | Documented the new metadata error reporting feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
prereq: #415