Skip to content

Conversation

@slowbackspace
Copy link
Contributor

@slowbackspace slowbackspace commented Sep 10, 2025

prereq: #415

@vercel
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
openapi Ready Ready Preview Comment Sep 18, 2025 8:38am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds error reporting functionality for metadata fetching failures by exposing structured error information when off-chain metadata cannot be fetched or validated. The change enables API consumers to understand why metadata retrieval failed and handle errors appropriately.

Key changes:

  • Added optional error object to metadata schemas with standardized error codes and human-readable messages
  • Updated TypeScript type definitions to reflect the new error field
  • Added comprehensive test coverage for the new error structure

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/schemas/pools/pool_metadata.yaml Added error object schema to pool metadata
src/schemas/pools/pool_list_extended.yaml Added error object schema to extended pool list metadata
src/schemas/governance/proposal_metadata_v2.yaml Added error object schema to governance proposal metadata
src/generated-types.ts Updated TypeScript interfaces with optional error field
openapi.yaml Updated OpenAPI specification with error object definitions
openapi.json Updated JSON OpenAPI specification with error object definitions
docs/blockfrost-openapi.yaml Updated documentation OpenAPI specification
blockfrost-openapi.yaml Updated public OpenAPI specification
test/tests/get-schema-for-endpoint.test.ts Added test coverage for error object schema and fixed quote consistency
test/tests/snapshots/get-schema-for-endpoint.test.ts.snap Updated test snapshots to include error object
CHANGELOG.md Documented the new metadata error reporting feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vladimirvolek vladimirvolek merged commit 3baecb5 into master Sep 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants