Skip to content

Conversation

@VerevkinAlexander
Copy link
Collaborator

General

Closes #118

Added abstract layer for the order book

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@VerevkinAlexander
Copy link
Collaborator Author

The task is in progress

@VerevkinAlexander
Copy link
Collaborator Author

createLimitOrder2 - used for order creation it can be replaced by htlc create
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1000
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1058

createPredictionShort - udate order
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L979
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1099
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1128

getTrackedGroupsConfig - get group order can be replaced by getHTLCs
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L517

cancelLimitOrder - cancel order
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1206

changeCurrentGroupLimit - changed groupLimit
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1234

checkFeeStatusAsync - get fee status
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L627

unSubscribeMarket -
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/Exchange.jsx#L1239

SubscribeMarket
https://github.com/blockchainprojects/bitshares-ui/blob/%232767_Abstract_Order_Book_First-Step/app/components/Exchange/ExchangeContainer.jsx#L284

@VerevkinAlexander
Copy link
Collaborator Author

@sschiessl-bcp please look. Is that what did you expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#2767 Abstract Order Book - First Step

1 participant