Fix/eslint standarjs conflicts on generator functions

[lzhuor]

Description

Standard JS requires spacing before and after * of a generator function.

We could fix this error using auto fix with ESLint's editor plugin (I'm on WebStorm). However, the space will be removed during pre-commit phase (lint-staged) and then editor will show lint error again. It becomes cyclic.

Change Type

Please enter one or more of the following:

• Other (eslint configuration)

Testing Steps

1. Fix spacing before and after * for generator functions
2. Commit and push code
3. There should be no errors about generator-star-spacing. The spacing added in step 1 should remain in code.

Code Checklist

• Code compiles successfully (verified via yarn start)
• README.md and other documentation is updated as needed

Fix #1522

[schnogz]

Also run yarn prettier && yarn lint:fix to apply rules to all files and commit those changes as well.

[lzhuor]

@schnogz thanks! Addressed comments and pushed them.

[schnogz]

i see we have a warning when running lint tasks: Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration .

Can you add a settings object to .eslintrc to fix this warning. Add the following snippet and the warning will go away.

"settings": {
    "react": {
      "version": "latest"
    }
  },

[lzhuor]

@schnogz , Could you please share which command generates that warning? Is it on circleci or local? It seems fine on my local. I have tried yarn lint, yarn lint:fix and yarn:frontend.

[lzhuor]

@schnogz Added. Thanks!