chore: use ssz instead of json in annotate validators#71
Conversation
Signed-off-by: Chen Kai <281165273grape@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR attempts to change the validator private key file format from JSON to SSZ by updating the filename extension in the node assignment output. The change modifies a single line where PRIVKEY_FILENAME is constructed to use .ssz instead of .json.
Key Changes:
- Updated validator private key filename extension from
.jsonto.sszin the node assignment generation logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -568,7 +568,7 @@ for idx in "${!ASSIGNMENT_NODE_NAMES[@]}"; do | |||
| fi | |||
|
|
|||
| PUBKEY_HEX_NO_PREFIX="${PUBKEY_HEX_VALUE#0x}" | |||
There was a problem hiding this comment.
The filename extension has been changed to .ssz, but there are multiple references throughout the codebase that still expect .json files. Specifically:
- Line 189 checks for validator_${i}_sk.json existence
- Line 261 reports creating validator_${i}_sk.json files
- Line 671 lists validator_${i}_sk.json in output
- ansible/roles/qlean/tasks/main.yml line 114 references sk.json
- client-cmds/qlean-cmd.sh line 24 references sk.json
- parse-vc.sh line 75 references sk.json
Additionally, the key generation command at line 251 uses --export-format both, but it's unclear whether this generates both .json and .ssz files or only one format. This mismatch will cause runtime failures when the code expects files with the .ssz extension but only .json files exist, or vice versa.
| PUBKEY_HEX_NO_PREFIX="${PUBKEY_HEX_VALUE#0x}" | |
| PUBKEY_HEX_NO_PREFIX="${PUBKEY_HEX_VALUE#0x}" | |
| # Note: The validator secret key file extension has changed from .json to .ssz for consistency. |
No description provided.