Implement Pagination for Mempool Indexer#657
Open
AkarshSahlot wants to merge 1 commit intoblock-core:mainfrom
Open
Implement Pagination for Mempool Indexer#657AkarshSahlot wants to merge 1 commit intoblock-core:mainfrom
AkarshSahlot wants to merge 1 commit intoblock-core:mainfrom
Conversation
dangershony
reviewed
Feb 16, 2026
|
|
||
| allTransactions.AddRange(trx.Select(t => MapToQueryTransaction(t))); | ||
|
|
||
| if (trx.Count < 50) |
Member
There was a problem hiding this comment.
No safety guard against infinite loops.
Make this happen max 10 times
dangershony
reviewed
Feb 16, 2026
| if (!response.IsSuccessStatusCode) | ||
| throw new InvalidOperationException(response.ReasonPhrase); | ||
|
|
||
| var trx = await response.Content.ReadFromJsonAsync<List<MempoolTransaction>>(new JsonSerializerOptions() |
Member
There was a problem hiding this comment.
JsonSerializerOptions re-allocated every iteration. It should be a static readonly
Member
|
delete the md files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654