Set underscore as a local #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed underscore as a local variable of the factory, fixing import with CommonJS or Node.
Merged
|
@blittle thanks for the super quick merge, that's awesome 👍 |
|
@mittsh thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed underscore as a local variable of the factory, fixing import with CommonJS or Node. The same way
Backbonewas passed as a parameter offactory(), this adds_(Underscore.js).Before this change, this fails us as we're trying to run Backbone + Backbone Nested Models in Node.js. All works fine except this detail.
Thanks for considering to merge this! I didn't bump the version number, let me know if you'd like to do so (I think it should be, but didn't want to make that decision on my own, probably
v2.0.1would be good).