Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct TX size calc for min-fee in Alonzo and later #967

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: use correct TX size calc for min-fee in Alonzo and later #967

merged 1 commit into from
Mar 25, 2025

Conversation

agaffney
Copy link
Contributor

  • subtract 1 byte from TX size in Alonzo+ when calculating fee
  • add error handling around CBOR encode that should "never fail"
  • rename 'IsTxValid' to 'TxIsValid' for consistency
  • change nil check to length check

@agaffney agaffney requested a review from a team as a code owner March 25, 2025 18:14
@agaffney
fix: use correct TX size calc for min-fee in Alonzo and later
11ae8ea 
* subtract 1 byte from TX size in Alonzo+ when calculating fee
* add error handling around CBOR encode that should "never fail"
* rename 'IsTxValid' to 'TxIsValid' for consistency
* change nil check to length check

Signed-off-by: Aurora Gaffney <aurora@blinklabs.io>
@agaffney agaffney force-pushed the fix/alonzo-min-fee branch from 0d5fa71 to 11ae8ea Compare March 25, 2025 18:21
@agaffney agaffney merged commit d308be0 into main Mar 25, 2025
9 checks passed
@agaffney agaffney deleted the fix/alonzo-min-fee branch March 25, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agaffney @wolf31o2