Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename StakeCredential to Credential #961

Conversation

goofy-liskov
Copy link
Contributor

@goofy-liskov goofy-liskov commented Mar 23, 2025

Closes #959

@goofy-liskov goofy-liskov requested a review from a team as a code owner March 23, 2025 19:28
Signed-off-by: goofy-liskov <zephiezephs@gmail.com>
@goofy-liskov goofy-liskov force-pushed the chore/rename-stakecredential-to-credential branch from bbb48a5 to 6bc5afc Compare March 23, 2025 19:33
@agaffney
Copy link
Contributor

Thanks for the contribution! This looks great, but we also want to rename the credential type constants to match

Signed-off-by: goofy-liskov <zephiezephs@gmail.com>
@goofy-liskov goofy-liskov force-pushed the chore/rename-stakecredential-to-credential branch from 40c5daa to c5670aa Compare March 23, 2025 19:52
@wolf31o2 wolf31o2 requested a review from agaffney March 23, 2025 20:29
@agaffney agaffney merged commit 9425192 into blinklabs-io:main Mar 23, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename StakeCredential to Credential in ledger/common
3 participants