Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ledger): Decode block header as proper era type #951

Merged
merged 3 commits into from
Mar 14, 2025
Merged

feat(ledger): Decode block header as proper era type #951

merged 3 commits into from
Mar 14, 2025

Conversation

arepala-uml
Copy link
Contributor

@arepala-uml arepala-uml commented Mar 13, 2025 •
edited
Loading

  1. Added changes for decoding specific block header type and written separate cases for Shelley/Allegra/Mary/Alonzo and Babbage/Conway in NewBlockHeaderFromCbor.
  2. Added unit test cases for each case to validate whether the correct corresponding function is executed in NewBlockHeaderFromCbor.

Closes #844

@arepala-uml arepala-uml marked this pull request as ready for review March 13, 2025 23:14
@arepala-uml arepala-uml requested a review from a team as a code owner March 13, 2025 23:15
wolf31o2
wolf31o2 requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple minor changes

@arepala-uml
refactor(block-header): Added changes for decoding block headers of d…
631de5b 
…ifferent shapes like Shelley/Allegra/Mary/Alonzo and Babbage/Conway.

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml
refactor(block-header): Added unit test cases for each block header t…
a245bbc 
…ype in NewBlockHeaderFromCbor

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml
refactor(block-header): Added a spearate block_test.go for validating…
61f4eab 
… whether the correct corresponding function is executed in NewBlockHeaderFromCbor.

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml requested a review from wolf31o2 March 14, 2025 17:38
@wolf31o2 wolf31o2 merged commit 489e47f into main Mar 14, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the decode_block branch March 14, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decode block header as proper era type
2 participants
@arepala-uml @wolf31o2