fix: don't activate protocol state timeout until after initial state

[agaffney]

Fixes #1262

---

Summary by cubic

Delay activation of protocol state timeouts until after the initial state is set to prevent premature transitions on startup. Fixes #1262.

• Bug Fixes
  • Added an initialStateSet guard so no timeout is scheduled during the initial protocol state.
  • Ensures stable startup by avoiding unintended timeouts immediately after initialization.

^{Written for commit 2f135b8. Summary will update automatically on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Fixed state transition handling during protocol initialization to prevent premature timeout activation, ensuring smoother startup and more reliable state management.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a state tracking mechanism to prevent protocol state transition timeouts from activating during the initial state. A new initialStateSet boolean flag is added to track whether the initial protocol state has been established. The setState method is modified with a guard condition to skip timeout activation when called before the initial state is set. During initialization, the initial state is explicitly applied via setState(p.config.InitialState) and the flag is marked as true, ensuring timeouts only begin after the protocol transitions away from its initial state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify guard logic: Confirm that the initialStateSet check correctly prevents timeout activation only during pre-initialization
• Initialization sequence: Ensure the initial state is properly set and the flag is marked true before any subsequent state transitions occur
• Edge case handling: Check for potential race conditions or scenarios where state transitions might occur during the initialization window
• Timeout behavior: Validate that timeouts are correctly applied to all non-initial state transitions

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main fix: preventing protocol state timeout activation until after the initial state is set, which directly addresses the primary objective.
Linked Issues check	✅ Passed	The PR successfully implements the primary requirement from issue #1262 by preventing per-state timeouts from being enforced until the protocol transitions out of its initial state.
Out of Scope Changes check	✅ Passed	All changes in protocol.go are directly scoped to addressing the linked issue; no unrelated modifications are present.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/protocol-init-state-timeout

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d95b170 and 2f135b8.

📒 Files selected for processing (1)

• protocol/protocol.go (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Analyze (go)

🔇 Additional comments (3)

protocol/protocol.go (3)

527-527: LGTM - Clean approach using a local flag.

The initialStateSet flag is scoped appropriately within the stateLoop goroutine, avoiding any concurrency concerns while clearly tracking the initialization state.

---

577-580: LGTM - Guard condition correctly placed.

The early return is positioned after state initialization and ready signaling but before timeout activation, ensuring the protocol is functional in its initial state without being time-limited. This aligns with the PR objective to defer timeouts until the protocol actively transitions.

---

596-598: LGTM - Initialization sequence is correct.

The initial state is set before the main event loop begins, and the flag is immediately marked afterward, ensuring all subsequent state transitions will properly activate timeouts. The sequential execution within the single stateLoop goroutine eliminates any race conditions.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file