Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move lock inside loop in consumed UTxO cleanup #248

Merged
merged 1 commit into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions state/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,14 @@ func (ls *LedgerState) scheduleCleanupConsumedUtxos() {
ls.timerCleanupConsumedUtxos = time.AfterFunc(
cleanupConsumedUtxosInterval,
func() {
ls.Lock()
defer func() {
// Unlock ledger state
ls.Unlock()
// Schedule the next run
ls.scheduleCleanupConsumedUtxos()
}()
// Get the current tip, since we're querying by slot
tip := ls.Tip()
for {
ls.Lock()
// Perform updates in a transaction
batchDone := false
txn := ls.db.Transaction(true)
Expand Down Expand Up @@ -255,6 +253,7 @@ func (ls *LedgerState) scheduleCleanupConsumedUtxos() {
}
return nil
})
ls.Unlock()
if err != nil {
ls.config.Logger.Error(
"failed to update utxos",
Expand Down