MB-61889: Address corner case with ivf_nprobe_pct #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
metonymic-smokey and
moshaad7
abhinavdangeti
force-pushed
the
nprobeMin
branch
3 times, most recently
from
06bd69b to
3f9fc80
Compare
+ With certain cluster counts within centroid indexes, a very low value for ivf_nprobe_pct can cause nprobe to be rounded down to 0, which would result in this error .. ``` Error in virtual void faiss::IndexIVF::search( faiss::idx_t, const float*, faiss::idx_t, float*, faiss::idx_t*, const faiss::SearchParameters*) const at /home/couchbase/.../faiss/faiss/IndexIVF.cpp:310: Error: 'nprobe > 0' failed ``` + In this event, we should be rounding up nprobe to 1 instead.
abhinavdangeti
force-pushed
the
nprobeMin
branch
from
3f9fc80 to
e18b829
Compare
moshaad7
previously approved these changes
Sep 4, 2024
moshaad7
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
low value for ivf_nprobe_pct can cause nprobe to be rounded
down to 0, which would result in this error ..