Minor code fixes #2252
Merged
Minor code fixes #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request optimizes memory allocation by reusing the ScoreBreakdown map across document matches instead of creating a new one each time. When a DocumentMatch is reset for reuse, the existing map is now preserved, cleared, and reassigned.
Key changes:
- Modified
DocumentMatch.Reset()to save, clear, and reuse theScoreBreakdownmap - Updated
DisjunctionQueryScorer.ScoreAndExplBreakdown()to check if the map exists before initializing a new one
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| search/search.go | Added logic to preserve and clear the ScoreBreakdown map during DocumentMatch reset for reuse |
| search/scorer/scorer_disjunction.go | Refactored to reuse the existing ScoreBreakdown map if present instead of always creating a new one |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
previously approved these changes
Dec 1, 2025
abhinavdangeti
previously approved these changes
Dec 1, 2025
abhinavdangeti
approved these changes
Dec 1, 2025
capemox
approved these changes
Dec 2, 2025
Likith101
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScoreBreakdownmap was always getting created, and not being reused. When recycling theDocumentMatch, clear out the score breakdown map and reuse it when needed.